Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Enum): handle Enum classes correctly #2702

Merged
merged 7 commits into from
Aug 10, 2023
Merged

fix(Enum): handle Enum classes correctly #2702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a62e0c6
fix enums
MrCloudSec Aug 10, 2023
19a6f37
fix emr_cluster_publicly_accesible
MrCloudSec Aug 10, 2023
e55d4f8
fix codeartifact_packages_external_public_publishing_disabled
MrCloudSec Aug 10, 2023
1aa200e
lambda is not necessary
MrCloudSec Aug 10, 2023
cf8918b
codeartifact is not necessary
MrCloudSec Aug 10, 2023
9a3efa8
ssm is not necessary
MrCloudSec Aug 10, 2023
aed058c
emr is not necessary
MrCloudSec Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...l_public_publishing_disabled/codeartifact_packages_external_public_publishing_disabled.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ def execute(self):
report.status = "PASS"
report.status_extended = f"Internal package {package.name} is not vulnerable to dependency confusion in repository {repository.arn}"

findings.append(report)
findings.append(report)

return findings
16 changes: 10 additions & 6 deletions prowler/providers/aws/services/directoryservice/directoryservice_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,17 @@ def __describe_directories__(self, regional_client):
):
directory_id = directory["DirectoryId"]
directory_name = directory["Name"]
directory_type = directory["Type"]
directory_type = DirectoryType(directory["Type"])
# Radius Configuration
radius_authentication_protocol = (
directory["RadiusSettings"]["AuthenticationProtocol"]
AuthenticationProtocol(
directory["RadiusSettings"]["AuthenticationProtocol"]
)
if "RadiusSettings" in directory
else None
)
radius_status = (
directory["RadiusStatus"]
RadiusStatus(directory["RadiusStatus"])
if "RadiusStatus" in directory
else None
)
Expand Down Expand Up @@ -114,7 +116,7 @@ def __describe_event_topics__(self, regional_client):
EventTopics(
topic_arn=event_topic["TopicArn"],
topic_name=event_topic["TopicName"],
status=event_topic["Status"],
status=EventTopicStatus(event_topic["Status"]),
created_date_time=event_topic["CreatedDateTime"],
)
)
Expand Down Expand Up @@ -147,11 +149,13 @@ def __list_certificates__(self, regional_client):
Certificate(
id=certificate_info["CertificateId"],
common_name=certificate_info["CommonName"],
state=certificate_info["State"],
state=CertificateState(
certificate_info["State"]
),
expiry_date_time=certificate_info[
"ExpiryDateTime"
],
type=certificate_info["Type"],
type=CertificateType(certificate_info["Type"]),
)
)
self.directories[directory.id].certificates = certificates
Expand Down
2 changes: 1 addition & 1 deletion ...oviders/aws/services/emr/emr_cluster_publicly_accesible/emr_cluster_publicly_accesible.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,6 @@ def execute(self):
else ""
)

findings.append(report)
findings.append(report)

return findings