Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): New check ec2_instance_detailed_monitoring_enabled #2735

Merged
merged 8 commits into from
Aug 16, 2023

Conversation

vysakh-devopspace
Copy link
Contributor

@vysakh-devopspace vysakh-devopspace commented Aug 16, 2023

Description

New EC2 check ec2_detailed_monitoring_enabled.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vysakh-devopspace vysakh-devopspace requested a review from a team August 16, 2023 06:52
@jfagoagas jfagoagas self-assigned this Aug 16, 2023
@jfagoagas jfagoagas changed the title Uploaded Detailed Monitoring Code for EC2 feat(ec2): New check ec2_detailed_monitoring_enabled Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2735 (54f6399) into master (e119458) will increase coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2735      +/-   ##
==========================================
+ Coverage   86.07%   86.08%   +0.01%     
==========================================
  Files         526      527       +1     
  Lines       17036    17059      +23     
==========================================
+ Hits        14663    14686      +23     
  Misses       2373     2373              
Files Changed Coverage Δ
...nabled/ec2_instance_detailed_monitoring_enabled.py 100.00% <100.00%> (ø)
prowler/providers/aws/services/ec2/ec2_service.py 94.09% <100.00%> (+0.08%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @vysakh-devopspace !!

@jfagoagas jfagoagas changed the title feat(ec2): New check ec2_detailed_monitoring_enabled feat(ec2): New check ec2_instance_detailed_monitoring_enabled Aug 16, 2023
@jfagoagas jfagoagas merged commit 54a9f41 into prowler-cloud:master Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants