Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecr_repositories_scan_vulnerabilities_in_latest_image): Minimum severity is configurable #2736

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Aug 16, 2023

Context

Fixes #2535

Description

Included a new config parameter ecr_repository_vulnerability_minimum_severity to set a minimum severity level for the ecr_repositories_scan_vulnerabilities_in_latest_image check.

Now you can get a FAIL finding only if a CRITICAL vulnerability is present in your ECR repository image.

The default behaviour is to set MEDIUM as the base severity level.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Aug 16, 2023
@jfagoagas jfagoagas self-assigned this Aug 16, 2023
@jfagoagas jfagoagas requested a review from a team August 16, 2023 08:34
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2736 (27e1858) into master (8f091e7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2736      +/-   ##
==========================================
+ Coverage   86.05%   86.07%   +0.01%     
==========================================
  Files         526      526              
  Lines       17037    17044       +7     
==========================================
+ Hits        14662    14671       +9     
+ Misses       2375     2373       -2     
Files Changed Coverage Δ
...positories_scan_vulnerabilities_in_latest_image.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jfagoagas jfagoagas force-pushed the PRWLR-2325-ecr-repositories-scan-vulnerabilities-in-latest-image-configure-level-2535 branch from aa12d73 to 27e1858 Compare August 16, 2023 08:51
@n4ch04 n4ch04 merged commit 7c45cb4 into master Aug 18, 2023
@n4ch04 n4ch04 deleted the PRWLR-2325-ecr-repositories-scan-vulnerabilities-in-latest-image-configure-level-2535 branch August 18, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ecr_repositories_scan_vulnerabilities_in_latest_image: Configure level
2 participants