Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(check_security_group) #2740

Merged
merged 1 commit into from
Aug 17, 2023
Merged

tests(check_security_group) #2740

merged 1 commit into from
Aug 17, 2023

Conversation

jfagoagas
Copy link
Member

Description

Include tests for the check_security_group function.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Aug 17, 2023
@jfagoagas jfagoagas self-assigned this Aug 17, 2023
@jfagoagas jfagoagas requested a review from a team August 17, 2023 09:02
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #2740 (e8aa27a) into master (54a9f41) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2740      +/-   ##
==========================================
+ Coverage   86.08%   86.13%   +0.04%     
==========================================
  Files         527      527              
  Lines       17059    17059              
==========================================
+ Hits        14686    14694       +8     
+ Misses       2373     2365       -8     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@toniblyx toniblyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfagoagas jfagoagas merged commit bc5a7a9 into master Aug 17, 2023
@jfagoagas jfagoagas deleted the test-sgs branch August 17, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants