fix(ec2_securitygroup_default_restrict_traffic): fix check only allow empty rules

[n4ch04]

Context

Check ec2_securitygroup_default_restrict_traffic was not checking if the sg was not denying all the traffic but if it was open to internet

Fixes: #2761

Description

Change logic of the check to test if the sg has egress and ingress rules

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[jfagoagas]

Awesome!

Thanks @jmanduca-psfy for reporting this!

[codecov]

Codecov Report

Merging #2777 (9805a25) into master (b17cc56) will decrease coverage by 0.02%.
Report is 9 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2777      +/-   ##
==========================================
- Coverage   86.23%   86.21%   -0.02%     
==========================================
  Files         536      537       +1     
  Lines       17261    17263       +2     
==========================================
- Hits        14885    14884       -1     
- Misses       2376     2379       +3     

Files Changed	Coverage Δ
...ffic/ec2_securitygroup_default_restrict_traffic.py	100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more