fix(ec2 tests): add region and delete search sg checks #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2788 +/- ##
==========================================
- Coverage 86.21% 86.20% -0.02%
==========================================
Files 537 537
Lines 17263 17263
==========================================
- Hits 14884 14882 -2
- Misses 2379 2381 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…t regions in tests
toniblyx
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There were tests in
ec2service that do not include all the report object attributes in the assertionsDescription
Review all the tests from the security_groups checks and include the assertion of the field
region.Also delete
searchassertionsLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.