fix(iam_inline_policy_no_administrative_privileges): set resource id as the entity name #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
added
provider/aws
Codecov Report
@@ Coverage Diff @@
## master #2820 +/- ##
==========================================
- Coverage 86.24% 86.14% -0.11%
==========================================
Files 538 539 +1
Lines 17292 17331 +39
==========================================
+ Hits 14913 14929 +16
- Misses 2379 2402 +23
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jfagoagas
reviewed
Sep 22, 2023
| @@ -10,7 +10,7 @@ def execute(self) -> Check_Report_AWS: | |||
| report = Check_Report_AWS(self.metadata()) | |||
| report.region = iam_client.region | |||
| report.resource_arn = policy.arn | |||
| report.resource_id = policy.name | |||
| report.resource_id = policy.entity | |||
There was a problem hiding this comment.
Why this change? Please include an explanation in the PR body.
Thanks!
There was a problem hiding this comment.
Because the inline policy it is not an unique resource and it may lead to duplicate finding IDs.
There was a problem hiding this comment.
I didn't see the "inline" part, totally agree then. Good catch!!
jfagoagas
deleted the
fix-iam_inline_policy_no_administrative_privileges
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set resource id as the entity name.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.