feat(iam): add new check iam_role_administratoraccess_policy #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and maps not to check122
…t and maps not to check122
MrCloudSec
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The existing check
iam_aws_attached_policy_no_administrative_privilegeswas not appropriate for us because it only lists the resource that the check was running on, in this case all"*:*"open policies such as the AWS managed policyAdministratorAccess, and not for every role where such a policy is attached to.However, we have some company-wide rules in place, to which the
AdministratorAccesspolicy is attached for good reasons. In order to be able to allowlist these roles, I wrote the new checkiam_role_administratoraccess_policy.Description
The new check
iam_role_administratoraccess_policyfails for roles where theAdministratorAccesspolicy is attached to. The check reports the role name so you may allowlist specific roles.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.