Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks_endpoints_not_publicly_accessible): handle endpoint private access #2825

Merged
merged 2 commits into from
Sep 22, 2023
Merged

fix(eks_endpoints_not_publicly_accessible): handle endpoint private access #2825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a68bc1
Update eks_endpoints_not_publicly_accessible.py
Fennerr Sep 11, 2023
3f56fa8
test(eks_endpoints_not_publicly_accessible): Assert tags and region
jfagoagas Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...rvices/eks/eks_endpoints_not_publicly_accessible/eks_endpoints_not_publicly_accessible.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def execute(self):
report.status_extended = (
f"Cluster endpoint access is private for EKS cluster {cluster.name}."
)
if cluster.endpoint_public_access and not cluster.endpoint_private_access:
if cluster.endpoint_public_access:
report.status = "FAIL"
report.status_extended = (
f"Cluster endpoint access is public for EKS cluster {cluster.name}."
Expand Down
4 changes: 4 additions & 0 deletions ...s/eks/eks_endpoints_not_publicly_accessible/eks_endpoints_not_publicly_accessible_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ def test_endpoint_public_access(self):
)
assert result[0].resource_id == cluster_name
assert result[0].resource_arn == cluster_arn
assert result[0].resource_tags == []
assert result[0].region == AWS_REGION

def test_endpoint_not_public_access(self):
eks_client = mock.MagicMock
Expand Down Expand Up @@ -91,3 +93,5 @@ def test_endpoint_not_public_access(self):
)
assert result[0].resource_id == cluster_name
assert result[0].resource_arn == cluster_arn
assert result[0].resource_tags == []
assert result[0].region == AWS_REGION