Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudtrail_s3_dataevents_read/write_enabled): Handle S3 ARN #2844

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

jfagoagas
Copy link
Member

Description

Handle S3 ARN arn:aws:s3:::

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Sep 15, 2023
@jfagoagas jfagoagas requested a review from a team September 15, 2023 08:33
@jfagoagas jfagoagas self-assigned this Sep 15, 2023
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #2844 (6f4d5e3) into master (bc11537) will decrease coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2844      +/-   ##
==========================================
- Coverage   86.25%   86.24%   -0.02%     
==========================================
  Files         539      539              
  Lines       17312    17312              
==========================================
- Hits        14933    14931       -2     
- Misses       2379     2381       +2     
Files Changed Coverage Δ
...d_enabled/cloudtrail_s3_dataevents_read_enabled.py 100.00% <ø> (ø)
..._enabled/cloudtrail_s3_dataevents_write_enabled.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCloudSec MrCloudSec merged commit a980b26 into master Sep 15, 2023
@MrCloudSec MrCloudSec deleted the fix-cloudtrail_s3_dataevents_read_enabled branch September 15, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants