Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ds): GetSnapshotLimits for MicrosoftAD #2859

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

jfagoagas
Copy link
Member

Description

GetSnapshotLimits is only supported for MicrosoftAD.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Sep 22, 2023
@jfagoagas jfagoagas requested a review from a team September 22, 2023 08:04
@jfagoagas jfagoagas self-assigned this Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #2859 (30939ae) into master (725e2e9) will decrease coverage by 0.04%.
Report is 1 commits behind head on master.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2859      +/-   ##
==========================================
- Coverage   86.27%   86.24%   -0.04%     
==========================================
  Files         539      539              
  Lines       17295    17298       +3     
==========================================
- Hits        14922    14919       -3     
- Misses       2373     2379       +6     
Files Changed Coverage Δ
...vices/directoryservice/directoryservice_service.py 88.55% <66.66%> (-1.02%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MrCloudSec MrCloudSec merged commit 2a5a07b into master Sep 22, 2023
@MrCloudSec MrCloudSec deleted the fix-GetSnapshotLimits branch September 22, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants