Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoscaling_find_secrets_ec2_launch_configuration): Fix UnicodeDecodeError #2870

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Sep 27, 2023

Description

Fix the following error autoscaling_find_secrets_ec2_launch_configuration -- UnicodeDecodeError[25]: 'utf-8' codec can't decode byte 0x8b in position 1: invalid start byte

I've included tests for the gzip files also moved some fixtures to the test folder.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Sep 27, 2023
@jfagoagas jfagoagas requested a review from a team September 27, 2023 06:52
@jfagoagas jfagoagas self-assigned this Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2870 (019a698) into master (1697e6a) will increase coverage by 0.00%.
Report is 5 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2870   +/-   ##
=======================================
  Coverage   86.12%   86.12%           
=======================================
  Files         539      539           
  Lines       17365    17373    +8     
=======================================
+ Hits        14955    14962    +7     
- Misses       2410     2411    +1     
Files Coverage Δ
...toscaling_find_secrets_ec2_launch_configuration.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@jfagoagas jfagoagas merged commit 4d6d58e into master Sep 28, 2023
@jfagoagas jfagoagas deleted the fix-UnicodeDecodeError branch September 28, 2023 15:13
jfagoagas added a commit to jit-contrib/prowler that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants