Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam credentials checks): unify logic #2883

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

n4ch04
Copy link
Contributor

@n4ch04 n4ch04 commented Oct 2, 2023

Context

In checks:

  • iam_disable_30_days_credentials
  • iam_disable_45_days_credentials
  • iam_disable_90_days_credentials
  • iam_rotate_access_key_90_days

there is present non unified logic

Description

Unify the logic with the general check logic

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@n4ch04 n4ch04 requested a review from a team October 2, 2023 09:07
@jfagoagas jfagoagas added the provider/aws Issues/PRs related with the AWS provider label Oct 2, 2023
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! Thanks @n4ch04 🚀

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #2883 (f5d4669) into master (f4ed014) will decrease coverage by 0.06%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #2883      +/-   ##
==========================================
- Coverage   86.12%   86.07%   -0.06%     
==========================================
  Files         539      539              
  Lines       17373    17431      +58     
==========================================
+ Hits        14963    15003      +40     
- Misses       2410     2428      +18     
Files Coverage Δ
...ays_credentials/iam_disable_90_days_credentials.py 98.33% <100.00%> (+0.33%) ⬆️
...ays_credentials/iam_disable_30_days_credentials.py 89.39% <75.00%> (-8.61%) ⬇️
...ays_credentials/iam_disable_45_days_credentials.py 89.39% <75.00%> (-8.61%) ⬇️
...ccess_key_90_days/iam_rotate_access_key_90_days.py 85.71% <75.00%> (-11.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@n4ch04 n4ch04 merged commit 2d89f57 into master Oct 2, 2023
@n4ch04 n4ch04 deleted the iam-credentials-checks-unify-logic branch October 2, 2023 09:28
jfagoagas pushed a commit to jit-contrib/prowler that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants