Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): add timeout and check HTTP errors #2886

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

MrCloudSec
Copy link
Member

Description

Check HTTP errors and add timeout

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested a review from a team October 2, 2023 11:21
jfagoagas
jfagoagas previously approved these changes Oct 2, 2023
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥷

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #2886 (8009cb8) into master (5831940) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2886      +/-   ##
==========================================
- Coverage   86.15%   86.14%   -0.01%     
==========================================
  Files         539      539              
  Lines       17430    17431       +1     
==========================================
  Hits        15016    15016              
- Misses       2414     2415       +1     
Files Coverage Δ
prowler/config/config.py 87.50% <0.00%> (-1.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MrCloudSec MrCloudSec merged commit 64f06b1 into master Oct 2, 2023
@MrCloudSec MrCloudSec deleted the improve-check-version branch October 2, 2023 12:44
jfagoagas pushed a commit to jit-contrib/prowler that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants