Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vpc_peering_routing_tables_with_least_privilege): check only peering routes #2887

Merged

Conversation

MrCloudSec
Copy link
Member

Description

Check only VpcPeeringConnection routes in vpc_peering_routing_tables_with_least_privilege.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested a review from a team October 2, 2023 13:53
@MrCloudSec MrCloudSec changed the title fix(vpc): vpc_peering_routing_tables_with_least_privilege fix(vpc_peering_routing_tables_with_least_privilege): check only peering routes Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #2887 (78a3e2f) into master (64f06b1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2887   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files         539      539           
  Lines       17431    17431           
=======================================
  Hits        15016    15016           
  Misses       2415     2415           
Files Coverage Δ
prowler/providers/aws/services/vpc/vpc_service.py 95.21% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good @sergargar but please include tests to cover this case. Thanks!

@MrCloudSec MrCloudSec merged commit 40318b8 into master Oct 2, 2023
@MrCloudSec MrCloudSec deleted the fix-vpc_peering_routing_tables_with_least_privilege branch October 2, 2023 14:20
jfagoagas pushed a commit to jit-contrib/prowler that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants