-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudwatch): ignore new lines in filters #2912
fix(cloudwatch): ignore new lines in filters #2912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great!
Could you please include a test for each check setting the filterPattern
with \n
? Like:
{\n ($.eventSource = config.amazonaws.com) &&\n (($.eventName=StopConfigurationRecorder)||\n ($.eventName=DeleteDeliveryChannel)||\n ($.eventName=PutDeliveryChannel)||\n ($.eventName=PutConfigurationRecorder))\n}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above comment.
Codecov Report
@@ Coverage Diff @@
## master #2912 +/- ##
=======================================
Coverage 86.18% 86.18%
=======================================
Files 539 539
Lines 17374 17374
=======================================
Hits 14974 14974
Misses 2400 2400
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Description
Add flag
re.DOTALL
to ignore new line characters in CloudWatch metric filters.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.