feat(report interface): add reporting interface call after report #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n4ch04
force-pushed
the
change-interface-reporting
branch
from
a8e17fc to
18daf43
Compare
Codecov Report
@@ Coverage Diff @@
## master #2948 +/- ##
========================================
Coverage 86.26% 86.26%
========================================
Files 551 559 +8
Lines 17652 17910 +258
========================================
+ Hits 15227 15450 +223
- Misses 2425 2460 +35
... and 22 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jfagoagas
requested changes
Oct 20, 2023
prowler/lib/check/check.py
Outdated
Comment on lines
563
to
565
| lib = os.environ["PROWLER_REPORT_LIB_PATH"] | ||
| outputs_module = importlib.import_module(lib) | ||
| curstom_report_interface = getattr(outputs_module, "report") |
There was a problem hiding this comment.
I think you have to handle more than a generic Exception here not to abort the execution if the "PROWLER_REPORT_LIB_PATH" is not present or if the import or getattr fails.
There was a problem hiding this comment.
Since the general report function is imported always we actually want Prowler to exit the execution if something wrong happens there
n4ch04
force-pushed
the
change-interface-reporting
branch
from
68acad2 to
18daf43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to have a more flexible custom report interface to suit our needs
Description
Import the custom report interface after
reportnative function has been performedLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.