Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource filters): add missing resource filters #2951

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

MrCloudSec
Copy link
Member

Description

Add missing resource filters to Neptune, DocDB and ElastiCache.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested a review from a team October 19, 2023 15:56
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergargar !!

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2951 (9dba760) into master (a46d7b2) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2951   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files         559      559           
  Lines       17902    17908    +6     
=======================================
+ Hits        15445    15451    +6     
  Misses       2457     2457           
Files Coverage Δ
...ders/aws/services/documentdb/documentdb_service.py 86.95% <100.00%> (+0.59%) ⬆️
...rs/aws/services/elasticache/elasticache_service.py 81.81% <100.00%> (+0.68%) ⬆️
.../providers/aws/services/neptune/neptune_service.py 82.45% <100.00%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MrCloudSec MrCloudSec merged commit 976d0da into master Oct 19, 2023
@MrCloudSec MrCloudSec deleted the add-missing-resource-filters branch October 19, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants