feat(allowlist): allowlist non-default regions configuration #2974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
requested changes
Oct 30, 2023
| @@ -188,10 +190,10 @@ def test_config_one_recorder_disabled_allowlisted(self): | |||
|
|
|||
| check = config_recorder_all_regions_enabled() | |||
| result = check.execute() | |||
| assert len(result) == 1 | |||
| assert len(result) == 2 | |||
Codecov Report
@@ Coverage Diff @@
## master #2974 +/- ##
==========================================
+ Coverage 86.28% 86.30% +0.02%
==========================================
Files 559 559
Lines 18074 18088 +14
==========================================
+ Hits 15595 15611 +16
+ Misses 2479 2477 -2
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jfagoagas
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
allowlist_non_default_regionsconfiguration variable to allowlist failed findings in non-default regions for GuardDuty, SecurityHub, DRS and Config AWS services.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.