Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(allowlist): Extract allowlist from report #2975

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

jfagoagas
Copy link
Member

Description

Extract the is_allowlisted function from the report function.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas added no-merge Please, DO NOT MERGE this PR. testing-pending labels Oct 27, 2023
@jfagoagas jfagoagas self-assigned this Oct 27, 2023
@jfagoagas jfagoagas requested a review from a team October 27, 2023 12:03
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #2975 (8d707b0) into master (008534d) will increase coverage by 0.01%.
Report is 8 commits behind head on master.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master    #2975      +/-   ##
==========================================
+ Coverage   86.28%   86.29%   +0.01%     
==========================================
  Files         559      559              
  Lines       18074    18080       +6     
==========================================
+ Hits        15595    15603       +8     
+ Misses       2479     2477       -2     
Files Coverage Δ
prowler/lib/outputs/outputs.py 45.09% <ø> (+0.75%) ⬆️
prowler/providers/aws/lib/allowlist/allowlist.py 77.93% <100.00%> (+1.28%) ⬆️
prowler/lib/check/check.py 46.17% <50.00%> (+0.02%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jfagoagas jfagoagas removed no-merge Please, DO NOT MERGE this PR. testing-pending labels Oct 30, 2023
Copy link
Member

@MrCloudSec MrCloudSec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@MrCloudSec MrCloudSec merged commit fcc56ad into master Oct 30, 2023
@MrCloudSec MrCloudSec deleted the refactor-report branch October 30, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants