fix(elbv2_desync_mitigation_mode): improve logic #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2986 +/- ##
=======================================
Coverage 86.30% 86.30%
=======================================
Files 559 559
Lines 18095 18095
=======================================
Hits 15616 15616
Misses 2479 2479
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jfagoagas
requested changes
Oct 31, 2023
| @@ -119,7 +119,7 @@ def test_elbv2_without_desync_mitigation_mode_and_not_dropping_headers(self): | |||
| assert len(result) == 1 | |||
| assert result[0].status == "FAIL" | |||
| assert search( | |||
| "does not have desync mitigation mode set as defensive or strictest and is not dropping invalid header fields", | |||
| "does not have desync mitigation mode set as strictest and is not dropping invalid header fields", | |||
There was a problem hiding this comment.
Please remove the search here. Don't you need to change the tests for them to pass?
There was a problem hiding this comment.
The search was already in there, and the result should be FAIL that's why they have passed.
jfagoagas
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to AWS Documentation, in order to ensure that your application load balancer receives only requests that comply with RFC 7230, it must have the strictest desync mitigation mode.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.