fix(clean local output dirs): clean dirs when output to s3 #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n4ch04
force-pushed
the
PRWLR-2641-delete-output-folder-when-sending-reports-to-bucket
branch
from
bee3008 to
dee643e
Compare
MrCloudSec
reviewed
Nov 6, 2023
Comment on lines
+305
to
+307
| # clean local directories | ||
| clean_provider_local_output_directories(args) | ||
|
|
There was a problem hiding this comment.
Make this function compatible with all providers or do the condition if args.output_bucket or args.output_bucket_no_assume here
Codecov Report
@@ Coverage Diff @@
## master #2997 +/- ##
==========================================
- Coverage 86.34% 86.33% -0.02%
==========================================
Files 559 560 +1
Lines 18108 18131 +23
==========================================
+ Hits 15636 15654 +18
- Misses 2472 2477 +5
... and 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
MrCloudSec
approved these changes
Nov 8, 2023
MrCloudSec
deleted the
PRWLR-2641-delete-output-folder-when-sending-reports-to-bucket
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When sending output to s3 bucket with a custom output directory we were not deleting that local output directory
Description
When options
output_bucketoroutput_bucket_no_assumeare set withoutput_directoryand that directory is not the default one -> delete itLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.