Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): check if engines exist in region #3012

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

MrCloudSec
Copy link
Member

Description

Check if RDS engines exist in region in check rds_instance_deprecated_engine_version

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested a review from a team November 8, 2023 12:49
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #3012 (6e197ab) into master (9182d56) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3012      +/-   ##
==========================================
+ Coverage   86.31%   86.33%   +0.02%     
==========================================
  Files         560      560              
  Lines       18123    18131       +8     
==========================================
+ Hits        15642    15654      +12     
+ Misses       2481     2477       -4     
Files Coverage Δ
..._version/rds_instance_deprecated_engine_version.py 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jfagoagas jfagoagas merged commit d9d7c00 into master Nov 10, 2023
@jfagoagas jfagoagas deleted the fix-rds-engine-check branch November 10, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants