Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): do not list tags for inline policies #3014

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

MrCloudSec
Copy link
Member

Description

Do not list tags for inline policies in IAM Service.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested a review from a team November 8, 2023 15:55
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #3014 (9e9bd52) into master (3325b72) will decrease coverage by 0.03%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3014      +/-   ##
==========================================
- Coverage   86.17%   86.15%   -0.03%     
==========================================
  Files         560      560              
  Lines       18173    18174       +1     
==========================================
- Hits        15661    15657       -4     
- Misses       2512     2517       +5     
Files Coverage Δ
prowler/providers/aws/services/iam/iam_service.py 74.64% <100.00%> (-0.57%) ⬇️

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jfagoagas jfagoagas merged commit 21fba27 into master Nov 10, 2023
@jfagoagas jfagoagas deleted the fix-iam-inline-tags branch November 10, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants