-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(azure): working version executing checks #3472
Merged
jfagoagas
merged 8 commits into
prowler-4.0-dev
from
PRWLR-3293-prowler-azure-remove-old-provider
Mar 1, 2024
Merged
chore(azure): working version executing checks #3472
jfagoagas
merged 8 commits into
prowler-4.0-dev
from
PRWLR-3293-prowler-azure-remove-old-provider
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrCloudSec
reviewed
Mar 1, 2024
@@ -16,9 +16,6 @@ def __init__( | |||
) | |||
|
|||
self.subscriptions = provider.identity.subscriptions | |||
# TODO: review locations | |||
self.locations = provider.locations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please leave, self.locations = provider.locations
….com:prowler-cloud/prowler into PRWLR-3293-prowler-azure-remove-old-provider
MrCloudSec
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
provider/aws
Issues/PRs related with the AWS provider
provider/azure
Issues/PRs related with the Azure provider
provider/gcp
Issues/PRs related with the Google Cloud Platform provider
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working version for the Azure provider without the previous version.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.