feat(cloudtrail): add threat detection checks for AWS (enum and priv escalation) #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## prowler-4.0-dev #3602 +/- ##
===================================================
- Coverage 86.09% 86.08% -0.02%
===================================================
Files 705 705
Lines 21851 21862 +11
===================================================
+ Hits 18813 18820 +7
- Misses 3038 3042 +4 ☔ View full report in Codecov by Sentry. |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
toniblyx
changed the title
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
|
You can check the documentation for this PR here -> SaaS Documentation |
toniblyx
requested changes
Mar 27, 2024
docs/tutorials/configuration_file.md
Outdated
| # aws.cloudtrail_threat_detection_privilege_escalation | ||
| # aws.cloudtrail_threat_detection_enumeration | ||
| threat_detection_entropy: 0.7 # 70% of actions found to decide if it is an attack event | ||
| threat_detection_minutes: 1 |
There was a problem hiding this comment.
Suggested change
| threat_detection_minutes: 1 | |
| threat_detection_minutes: 1440 # 1 day to search back from now |
prowler/config/config.yaml
Outdated
| # AWS CloudTrail Configuration | ||
| # aws.cloudtrail_threat_detection_privilege_escalation | ||
| threat_detection_privilege_escalation_entropy: 0.7 # Percentage of actions found to decide if it is an privilege_escalation attack event, by default is 0.7 (70%) | ||
| threat_detection_privilege_escalation_minutes: 1440 # Past minutes to check for privilege_escalation attacks, by default is 1440 minutes (24 hours) |
There was a problem hiding this comment.
Suggested change
| threat_detection_privilege_escalation_minutes: 1440 # Past minutes to check for privilege_escalation attacks, by default is 1440 minutes (24 hours) | |
| threat_detection_privilege_escalation_minutes: 1440 # Past minutes to search from now for privilege_escalation attacks, by default is 1440 minutes (24 hours) |
prowler/config/config.yaml
Outdated
| ] | ||
| # aws.cloudtrail_threat_detection_enumeration | ||
| threat_detection_enumeration_entropy: 0.7 # Percentage of actions found to decide if it is an enumeration attack event, by default is 0.7 (70%) | ||
| threat_detection_enumeration_minutes: 1440 # Past minutes to check for enumeration attacks, by default is 1440 minutes (24 hours) |
There was a problem hiding this comment.
Suggested change
| threat_detection_enumeration_minutes: 1440 # Past minutes to check for enumeration attacks, by default is 1440 minutes (24 hours) | |
| threat_detection_enumeration_minutes: 1440 # Past minutes to search from now for enumeration attacks, by default is 1440 minutes (24 hours) |
|
You can check the documentation for this PR here -> SaaS Documentation |
toniblyx
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 2 Threat Detection checks that only run if category is invoked directly. THESE DONT RUN WITH ALL CHECKS due to performance.
Runs these check only if
--category threat-detectionis set.I.e.:
prowler aws --category threat-detectionLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.