Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): normalize tenant domain set in checks #3641

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

MrCloudSec
Copy link
Member

Description

Normalize tenant domain set in checks by removing the quotes.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested a review from a team April 2, 2024 14:35
@github-actions github-actions bot added the provider/azure Issues/PRs related with the Azure provider label Apr 2, 2024
Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (be19ec5) to head (0c3e8a7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3641      +/-   ##
==========================================
+ Coverage   86.00%   86.04%   +0.03%     
==========================================
  Files         706      706              
  Lines       21798    21798              
==========================================
+ Hits        18747    18755       +8     
+ Misses       3051     3043       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfagoagas jfagoagas merged commit 88f8c1a into master Apr 2, 2024
10 of 11 checks passed
@jfagoagas jfagoagas deleted the fix-tenant-name branch April 2, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/azure Issues/PRs related with the Azure provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants