fix(json-ocsf): add check_id field in json-ocsf output #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3740 +/- ##
=======================================
Coverage 85.77% 85.78%
=======================================
Files 722 722
Lines 22434 22433 -1
=======================================
+ Hits 19243 19244 +1
+ Misses 3191 3189 -2 ☔ View full report in Codecov by Sentry. |
jfagoagas
requested changes
Apr 10, 2024
| @@ -107,6 +107,7 @@ def fill_json_ocsf(finding_output: FindingOutput) -> DetectionFinding: | |||
| ), | |||
| type_uid=DetectionFindingTypeID.Create, | |||
| type_name=DetectionFindingTypeID.Create.name, | |||
| unmapped_data={"check_id": finding_output.check_id}, | |||
There was a problem hiding this comment.
Suggested change
| unmapped_data={"check_id": finding_output.check_id}, | |
| unmapped={"check_id": finding_output.check_id}, |
Review the format here https://schema.ocsf.io/1.1.0/classes/detection_finding?extensions=
There was a problem hiding this comment.
Hey! @jfagoagas just fixed py-ocsf-models in this pr: prowler-cloud/py-ocsf-models#32 once it is updated I will apply the change.
Thanks for the catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pr adds new field check_id inside unmapped_data for json-ocsf output.
Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.