chore(fixer): improve fixer logic and include more #3750

MrCloudSec · 2024-04-10T13:46:17Z

Description

• Add 8 fixers
• Add fixer config file among --config-fixer flag.
• Improve fixer execution
• Add documentation

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions · 2024-04-10T13:46:31Z

You can check the documentation for this PR here -> SaaS Documentation

github-actions · 2024-04-10T15:30:53Z

You can check the documentation for this PR here -> SaaS Documentation

github-actions · 2024-04-10T15:39:18Z

You can check the documentation for this PR here -> SaaS Documentation

jfagoagas

Thats a great improvement @sergargar !!! 👏

Please review my comments and add tests for all the new included fixers, thanks!

docs/tutorials/fixer.md

jfagoagas · 2024-04-11T06:31:21Z

docs/tutorials/fixer.md

+    ```
+
+## Writing a Fixer
+To write a fixer, you need to create a file called `<check_id>_fixer.py` inside the check folder, with a function called `fixer` that receives either the region or the resource to be fixed as a parameter, and returns a boolean value indicating if the fix was successful or not.


What if the fixer needs the region and the resource_id?

It is not contemplated, but good point...

jfagoagas · 2024-04-11T06:33:49Z

prowler/lib/check/check.py

@@ -462,15 +468,18 @@ def run_check(check: Check, output_options) -> list:
        return findings


-def run_fixer(check_findings: list):
+def run_fixer(check_findings: list) -> int:


Do we have tests for this function? If not please add some.

jfagoagas · 2024-04-11T06:36:49Z

prowler/lib/check/check.py

+                                    fixed_findings += 1
+                                    print(f"\t{Fore.GREEN}DONE{Style.RESET_ALL}")
+                                else:
+                                    print(f"\t{Fore.RED}ERROR{Style.RESET_ALL}")


Can you move this to a function not to repeat it? Something like print_fixer_result.

...er/providers/aws/services/iam/iam_password_policy_number/iam_password_policy_number_fixer.py

...roviders/aws/services/iam/iam_password_policy_reuse_24/iam_password_policy_reuse_24_fixer.py

...er/providers/aws/services/iam/iam_password_policy_symbol/iam_password_policy_symbol_fixer.py

...viders/aws/services/iam/iam_password_policy_uppercase/iam_password_policy_uppercase_fixer.py

jfagoagas · 2024-04-11T06:45:16Z

...ices/s3/s3_account_level_public_access_blocks/s3_account_level_public_access_blocks_fixer.py

+        bool: True if S3 Block Public Access is enabled, False otherwise
+    """
+    try:
+        s3control_client.client.put_public_access_block(


Please add a test for this function.

github-actions · 2024-04-15T08:24:29Z

You can check the documentation for this PR here -> SaaS Documentation

Co-authored-by: Pepe Fagoaga <[email protected]>

github-actions · 2024-04-15T08:25:02Z

You can check the documentation for this PR here -> SaaS Documentation

github-actions · 2024-04-15T09:39:17Z

You can check the documentation for this PR here -> SaaS Documentation

github-actions · 2024-04-15T09:39:53Z

You can check the documentation for this PR here -> SaaS Documentation

github-actions · 2024-04-15T11:40:27Z

You can check the documentation for this PR here -> SaaS Documentation

...within_90_days_or_less/iam_password_policy_expires_passwords_within_90_days_or_less_fixer.py

github-actions · 2024-04-15T11:51:38Z

You can check the documentation for this PR here -> SaaS Documentation

github-actions · 2024-04-15T11:57:51Z

You can check the documentation for this PR here -> SaaS Documentation

jfagoagas

Awesome! Thanks for taking care of the comments 🚀

Co-authored-by: sergargar <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Pepe Fagoaga <[email protected]>

Co-authored-by: pedrooot <[email protected]>

…er guide (#3749) Co-authored-by: Pepe Fagoaga <[email protected]>

Co-authored-by: sergargar <[email protected]>

…#3756) Co-authored-by: Pepe Fagoaga <[email protected]>

Co-authored-by: Pepe Fagoaga <[email protected]>

github-actions · 2024-04-15T15:09:03Z

You can check the documentation for this PR here -> SaaS Documentation

github-actions · 2024-04-15T15:10:29Z

You can check the documentation for this PR here -> SaaS Documentation

codecov · 2024-04-15T15:27:30Z

Codecov Report

Attention: Patch coverage is 64.34109% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 85.49%. Comparing base (fc7ec18) to head (d6099ea).

Files	Patch %	Lines
prowler/lib/check/check.py	16.66%	15 Missing ⚠️
prowler/__main__.py	0.00%	4 Missing ⚠️
..._expires_passwords_within_90_days_or_less_fixer.py	66.66%	3 Missing ⚠️
...y_lowercase/iam_password_policy_lowercase_fixer.py	66.66%	3 Missing ⚠️
..._14/iam_password_policy_minimum_length_14_fixer.py	66.66%	3 Missing ⚠️
..._policy_number/iam_password_policy_number_fixer.py	66.66%	3 Missing ⚠️
...icy_reuse_24/iam_password_policy_reuse_24_fixer.py	66.66%	3 Missing ⚠️
..._policy_symbol/iam_password_policy_symbol_fixer.py	66.66%	3 Missing ⚠️
...y_uppercase/iam_password_policy_uppercase_fixer.py	66.66%	3 Missing ⚠️
...cks/s3_account_level_public_access_blocks_fixer.py	66.66%	3 Missing ⚠️
... and 3 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3750      +/-   ##
==========================================
- Coverage   85.61%   85.49%   -0.12%     
==========================================
  Files         722      731       +9     
  Lines       22527    22653     +126     
==========================================
+ Hits        19286    19368      +82     
- Misses       3241     3285      +44

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jfagoagas · 2024-04-15T15:41:29Z

tests/config/fixtures/config.yaml

@@ -1,3 +1,5 @@
+# TODO: UPDATE YAML


What is this?

To update the config yaml with the latest changes, meaning that we have to update the tests.

I didn't saw that it was the fixtures one, thanks!

chore(fixer): improve fixer logic and include more

1e0f2bb

MrCloudSec requested a review from a team April 10, 2024 13:46

fix tests

489a01f

fix more tests

00bf182

jfagoagas requested changes Apr 11, 2024

View reviewed changes

solve comments

63dc053

MrCloudSec requested a review from a team April 15, 2024 08:24

fix spaces

a478025

Co-authored-by: Pepe Fagoaga <[email protected]>

change flag name

a4df177

change flag name

c928ba0

add tests

a7db3fa

MrCloudSec commented Apr 15, 2024

View reviewed changes

...within_90_days_or_less/iam_password_policy_expires_passwords_within_90_days_or_less_fixer.py Outdated Show resolved Hide resolved

remove print

7a098d6

fix fixer

7d01ac5

jfagoagas previously approved these changes Apr 15, 2024

View reviewed changes

jfagoagas and others added 18 commits April 15, 2024 17:05

chore(dashboard): Use Prowler CLI parser (#3722)

b4281d3

fix(ocsf): Include check_id as metadata.event_code (#3748)

08484fe

chore(regions_update): Changes in regions for AWS services. (#3755)

a9046ad

Co-authored-by: sergargar <[email protected]>

chore(deps): bump idna from 3.6 to 3.7 (#3758)

f46f6f4

Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

docs(threat-detection): Add threat-detection docs (#3757)

752389b

fix(json-ocsf): Remove risk field from unmapped (#3759)

45f192f

Co-authored-by: Pepe Fagoaga <[email protected]>

fix(wafv2): Handle WAFNonexistentItemException (#3761)

c7e8a4e

fix(compliance): Add muted info to compliance outputs (#3751)

bed1871

fix(mutelist): if all fails are muted do exit 0 (#3754)

ac610ae

chore(codeowners): Add prowler-dev team (#3763)

17fe320

fix(ocsf): Add compliance (#3753)

c91a6e7

Co-authored-by: pedrooot <[email protected]>

docs(compliance): Change images for compliance (#3760)

ecd6442

docs(devel-guide): Adding some improves and clarifications to develop…

04f67a9

…er guide (#3749) Co-authored-by: Pepe Fagoaga <[email protected]>

chore(regions_update): Changes in regions for AWS services. (#3765)

f5cb77f

Co-authored-by: sergargar <[email protected]>

fix(security-hub): MUTED -> WARNING (#3768)

d4f4e40

docs(devel-guide): Add provider section and remove audit_info section (…

11a4ab3

…#3756) Co-authored-by: Pepe Fagoaga <[email protected]>

docs(unit-testing): Update the unit testing section (#3764)

776593d

Co-authored-by: Pepe Fagoaga <[email protected]>

fix(slack): Use global provider object (#3770)

8e61da2

MrCloudSec and others added 2 commits April 15, 2024 17:09

fix tests

bf8009f

Merge branch 'master' into fixers-part-2

d6099ea

MrCloudSec requested a review from jfagoagas April 15, 2024 15:13

jfagoagas reviewed Apr 15, 2024

View reviewed changes

jfagoagas self-requested a review April 15, 2024 15:44

jfagoagas approved these changes Apr 15, 2024

View reviewed changes

jfagoagas merged commit 99bd637 into master Apr 15, 2024
10 of 12 checks passed

jfagoagas deleted the fixers-part-2 branch April 15, 2024 15:45

jfagoagas assigned MrCloudSec Apr 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(fixer): improve fixer logic and include more #3750

chore(fixer): improve fixer logic and include more #3750

MrCloudSec commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

jfagoagas left a comment

jfagoagas Apr 11, 2024

MrCloudSec Apr 15, 2024

jfagoagas Apr 11, 2024

jfagoagas Apr 11, 2024

jfagoagas Apr 11, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

jfagoagas left a comment

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

codecov bot commented Apr 15, 2024 •

edited

Loading

jfagoagas Apr 15, 2024

MrCloudSec Apr 15, 2024

jfagoagas Apr 15, 2024

chore(fixer): improve fixer logic and include more #3750

chore(fixer): improve fixer logic and include more #3750

Conversation

MrCloudSec commented Apr 10, 2024

Description

License

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

github-actions bot commented Apr 10, 2024

jfagoagas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

jfagoagas left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 15, 2024

github-actions bot commented Apr 15, 2024

codecov bot commented Apr 15, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Apr 15, 2024 •

edited

Loading