-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws): not show findings when AccessDenieds #3803
Conversation
We need to cover the case when there is a region denied and other accessible. EDIT: DONE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great work and improvement @sergargar 👏
Please, document the criteria followed in the services and how this needs to be done in the checks, include all in the developer guide since it's an important change.
It'd be super helpful to complete tests cases and cover this, you can use mock_object.side_effect = ClientError(error_response, operation_name)
to raise exceptions like if boto3 does that.
Thanks!
..._operations/account_maintain_different_contact_details_to_security_billing_and_operations.py
Outdated
Show resolved
Hide resolved
prowler/providers/aws/services/backup/backup_vaults_exist/backup_vaults_exist.py
Show resolved
Hide resolved
...nges_to_network_acls_alarm_configured/cloudwatch_changes_to_network_acls_alarm_configured.py
Outdated
Show resolved
Hide resolved
...nges_to_network_acls_alarm_configured/cloudwatch_changes_to_network_acls_alarm_configured.py
Outdated
Show resolved
Hide resolved
.../providers/aws/services/iam/iam_securityaudit_role_created/iam_securityaudit_role_created.py
Show resolved
Hide resolved
prowler/providers/aws/services/iam/iam_support_role_created/iam_support_role_created.py
Show resolved
Hide resolved
@jfagoagas re-review it whenever you get a chance, please! Only the tests and docs are pending. |
You can check the documentation for this PR here -> SaaS Documentation |
Pending testing for CloudTrail, CloudWatch and IAM. |
You can check the documentation for this PR here -> SaaS Documentation |
Pending testing for CloudTrail and CloudWatch. |
You can check the documentation for this PR here -> SaaS Documentation |
Pending testing for CloudWatch. |
You can check the documentation for this PR here -> SaaS Documentation |
Description
Don't add findings when Prowler does not know the status of the resource because of an AccessDenied.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.