fix(aws): Include record names for dangling IPs #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3821 +/- ##
==========================================
+ Coverage 85.45% 85.50% +0.04%
==========================================
Files 737 737
Lines 22811 22810 -1
==========================================
+ Hits 19494 19503 +9
+ Misses 3317 3307 -10 ☔ View full report in Codecov by Sentry. |
jfagoagas
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
That's a great addition @rieck-srlabs 👏 Thanks for this contribution.
I've made some changes in the tests since I expected them to fail and the I realised the asserts wasn't good enough.
jfagoagas
changed the title
MrCloudSec
pushed a commit
that referenced
this pull request
Apr 22, 2024
Co-authored-by: Pepe Fagoaga <[email protected]>
MrCloudSec
pushed a commit
that referenced
this pull request
Apr 22, 2024
Co-authored-by: Pepe Fagoaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #3820
Improves the "Status Extended" output field for the
route53_dangling_ip_subdomain_takeovercheck.Description
This PR adds record set names to the "Status Extended" output of the check that identifies dangling IPs in AWS Route 53. It fixes an issue where currently identical findings are produced if one dangling IP is mapped to multiple record names in Route 53 and improves the rule's output in all cases. See #3820 for more information.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.