chore(get_tagged_resources): Add return value type hint #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add type hint for get_tagged_resources returned value.
github-actions
bot
added
the
provider/aws
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3860 +/- ##
=======================================
Coverage 85.51% 85.52%
=======================================
Files 741 741
Lines 22886 22890 +4
=======================================
+ Hits 19572 19576 +4
Misses 3314 3314 ☔ View full report in Codecov by Sentry. |
jfagoagas
requested changes
Apr 26, 2024
| @@ -630,7 +630,7 @@ def get_regions_from_audit_resources(self, audit_resources: list) -> set: | |||
| audited_regions.add(region) | |||
| return audited_regions | |||
|
|
|||
| def get_tagged_resources(self, input_resource_tags: list[str]): | |||
| def get_tagged_resources(self, input_resource_tags: list[str]) -> list[dict]: | |||
There was a problem hiding this comment.
Why list[dict]? This function returns a list of strings with ARNs.
jfagoagas
changed the title
jfagoagas
reviewed
Apr 26, 2024
jfagoagas
approved these changes
Apr 26, 2024
|
Thanks for you contribution @mlmerchant 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adding missing PEP 484 compliant type hints.
Description
Function get_tagged_resources was missing type hint for returned value.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.