Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typo): some comments #3900

Merged
merged 1 commit into from
Apr 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dashboard/pages/overview.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def load_csv_files(csv_files):
# Handle the case where there is location column
if "LOCATION" in data.columns:
data["REGION"] = data["LOCATION"]
# Hande the case where there is no region column
# Handle the case where there is no region column
if "REGION" not in data.columns:
data["REGION"] = "-"
# Handle the case where the region is null
Expand Down Expand Up @@ -685,7 +685,7 @@ def filter_data(
########################################################
"""Line PLOT 1"""
########################################################
# Formating date columns
# Formatting date columns
filtered_data_sp["TIMESTAMP_formatted"] = pd.to_datetime(
filtered_data_sp["TIMESTAMP"]
).dt.strftime("%Y-%m-%d")
Expand Down
2 changes: 1 addition & 1 deletion docs/developer-guide/unit-testing.md
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ Then, at the check_level when Python tries to import the client with `from prowl

### Services

For testing the AWS services we have to follow the same logic as with the AWS checks, we have to check if the AWS API calls made by the service are covered by Moto and we have to test the service `__init__` to verifiy that the information is being correctly retrieved.
For testing the AWS services we have to follow the same logic as with the AWS checks, we have to check if the AWS API calls made by the service are covered by Moto and we have to test the service `__init__` to verify that the information is being correctly retrieved.

The service tests could act as *Integration Tests* since we test how the service retrieves the information from the provider, but since Moto or the custom mock objects mocks that calls this test will fall into *Unit Tests*.

Expand Down
2 changes: 1 addition & 1 deletion prowler/providers/aws/lib/service/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
class AWSService:
"""The AWSService class offers a parent class for each AWS Service to generate:
- AWS Regional Clients
- Shared information like the account ID and ARN, the the AWS partition and the checks audited
- Shared information like the account ID and ARN, the AWS partition and the checks audited
- AWS Session
- Thread pool for the __threading_call__
- Also handles if the AWS Service is Global
Expand Down