Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): support more AWS RDS DB Instance engines in encryption check #3968

Merged
merged 1 commit into from
May 10, 2024
Merged

chore(rds): support more AWS RDS DB Instance engines in encryption check #3968

merged 1 commit into from
May 10, 2024

Conversation

madereddy
Copy link
Contributor

Context

Add additional RDS transport level encryption logic for supported RDS versions:

For SQL Server, PostgreSQL and Aurora PostgreSQL databases, if the rds.force_ssl parameter value is set to 0, the Transport Encryption feature is not enabled. For MySQL, Aurora MySQL and MariaDB databases, if the require_secure_transport parameter value is set to OFF, the Transport Encryption feature is not enabled.

Description

Added additional checks for MySQL, MariaDB, Aurora PostgreSQL, and Aurora MySQL DB instances.

Corrected Microsoft SQL Server checks as well to include all the engine versions available.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@madereddy madereddy requested review from a team May 9, 2024 16:31
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label May 9, 2024
@madereddy
Copy link
Contributor Author

Taking place over #3964 to keep a clean commit.

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.52%. Comparing base (ebe3c5d) to head (e210238).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3968      +/-   ##
==========================================
+ Coverage   86.44%   86.52%   +0.07%     
==========================================
  Files         768      768              
  Lines       23884    23889       +5     
==========================================
+ Hits        20646    20669      +23     
+ Misses       3238     3220      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec changed the title feat(rds): support more AWS RDS DB Instance engines in encryption check chore(rds): support more AWS RDS DB Instance engines in encryption check May 10, 2024
@jfagoagas jfagoagas merged commit 6601b42 into prowler-cloud:master May 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants