Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes): Handle empty --kubeconfig-file #3980

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented May 13, 2024

Context

#3845

When running Prowler in Kubernetes, --kubeconfig-file is needed.

Description

Sets the --kubeconfig-file to its default route if it's not set

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team May 13, 2024 10:09
@github-actions github-actions bot added the provider/kubernetes Issues/PRs related with the Kubernetes provider label May 13, 2024
@pedrooot pedrooot added the no-merge Please, DO NOT MERGE this PR. label May 13, 2024
@MrCloudSec
Copy link
Member

Good idea @pedrooot , but for in-cluster executions, the kubeconfig file is not needed.

Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

@MrCloudSec MrCloudSec removed the no-merge Please, DO NOT MERGE this PR. label May 15, 2024
MrCloudSec
MrCloudSec previously approved these changes May 15, 2024
@MrCloudSec MrCloudSec changed the title feat(kubernetes): Handle empty --kubeconfig_file feat(kubernetes): Handle empty --kubeconfig-file May 15, 2024
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label May 15, 2024
Copy link
Contributor

You can check the documentation for this PR here -> SaaS Documentation

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 86.51%. Comparing base (45ccd7e) to head (7bce4eb).
Report is 10 commits behind head on master.

Files Patch % Lines
...rowler/providers/kubernetes/kubernetes_provider.py 10.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3980   +/-   ##
=======================================
  Coverage   86.51%   86.51%           
=======================================
  Files         768      768           
  Lines       23899    23901    +2     
=======================================
+ Hits        20677    20679    +2     
  Misses       3222     3222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCloudSec MrCloudSec merged commit c33c3e3 into master May 15, 2024
11 of 12 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-3634-prowler-handle-no-arguments-with-context-and-namespace-for-the-k-8-s-provider branch May 15, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation github_actions Pull requests that update GitHub Actions code provider/kubernetes Issues/PRs related with the Kubernetes provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants