Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigatewayv2): managed exception NotFoundException #6576

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

HugoPBrito
Copy link
Member

Context

We were not handling correctly exception NotFoundException in service apigatewayv2.

Description

A new logic has been implemented to properly handle the exception, and a test has been added to verify its functionality.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners January 17, 2025 08:46
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Jan 17, 2025
@jfagoagas jfagoagas added backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.1 Backport PR to the v5.1 branch labels Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.41%. Comparing base (54d87fa) to head (860596d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6576      +/-   ##
==========================================
- Coverage   93.70%   89.41%   -4.29%     
==========================================
  Files          66     1182    +1116     
  Lines        6340    33790   +27450     
==========================================
+ Hits         5941    30214   +24273     
- Misses        399     3576    +3177     
Flag Coverage Δ
api ?
prowler 89.41% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 89.41% <80.00%> (∅)
api ∅ <ø> (∅)

@MrCloudSec MrCloudSec merged commit 166d9f8 into master Jan 17, 2025
11 of 13 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5965-fix-apigw-2-error-warning branch January 17, 2025 13:17
@prowler-bot prowler-bot added the was-backported The PR was successfully backported to the target branch label Jan 17, 2025
@prowler-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
v4.6
v5.1

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v4.6 Backport PR to the v4.6 branch backport-to-v5.1 Backport PR to the v5.1 branch provider/aws Issues/PRs related with the AWS provider was-backported The PR was successfully backported to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants