Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assume-role: check if -T and -A options are set together @jfagoagas #945

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

jfagoagas
Copy link
Member

@jfagoagas jfagoagas commented Nov 28, 2021

Check if -T and -A options are set together.

If not Prowler is executed with the default profile if present and I think this is not the expected behaviour.

e.g.:
./prowler -R test-role -T 1800 -g group1 --> it is executed with the default profile because -A is not set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jfagoagas jfagoagas changed the title fix(assumed-role): Check if -T and -A options are set together fix(assume-role): Check if -T and -A options are set together Nov 28, 2021
@toniblyx toniblyx changed the base branch from master to 2.7 November 29, 2021 09:56
@toniblyx toniblyx changed the title fix(assume-role): Check if -T and -A options are set together Fix assume-role: check if -T and -A options are set together @jfagoagas Nov 29, 2021
@toniblyx toniblyx merged commit 315b4cc into prowler-cloud:2.7 Nov 29, 2021
@jfagoagas jfagoagas deleted the fix-assumed-role-options branch November 29, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants