Fix and clean assume-role to better handle AWS STS CLI errors @jfagoagas #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
force-pushed
the
fix-aws-sts-handle-errors
branch
from
d7d005f to
352f483
Compare
jfagoagas
force-pushed
the
fix-aws-sts-handle-errors
branch
from
352f483 to
63eb184
Compare
toniblyx
changed the title
|
@jfagoagas this has some conflicts now, after merging the previous one, can you give it a look please? |
Done! |
toniblyx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a better error management for AWS STS CLI when assuming an IAM Role.
Also, the code including
ROLE_EXTERNAL_IDhas been simplified.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.