Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression tests for Black’s previous inconsistent quote formatting with adjacent string literals #4580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rdrll
Copy link
Contributor

@rdrll rdrll commented Feb 19, 2025

Description

Issue #3623 appears to be resolved, added regression tests to monitor this formatting issue and track any potential recurrence.

Regression tests were created based on Black's current stable version (25.1.0) formatting results, see Black Playground.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@MeGaGiGaGon MeGaGiGaGon added the skip news Pull requests that don't need a changelog entry. label Feb 19, 2025
@MeGaGiGaGon
Copy link
Collaborator

Given the name of this file fstring.py the tests could be merged into it, but I'm largely indifferent to if they are merged or get their own file so I'll leave that choice to the people with merge power. Other than that LGTM, thanks for the contribution!

@rdrll
Copy link
Contributor Author

rdrll commented Feb 19, 2025

Thanks for adding the label. I separated it since #3623's root cause is unclear and may differ from existing f-string coverage. Having a seperate test file could potentially ease future investigation, but I’m fine with either approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news Pull requests that don't need a changelog entry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants