Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove --py36 #724

Merged
merged 4 commits into from
Feb 24, 2019
Merged

remove --py36 #724

merged 4 commits into from
Feb 24, 2019

Conversation

JelleZijlstra
Copy link
Collaborator

Fixes #703.

@JelleZijlstra JelleZijlstra requested a review from zsol February 23, 2019 05:58
@coveralls
Copy link

coveralls commented Feb 23, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 931

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 96.073%
Totals Coverage Status
Change from base Build 930: 0.1%
Covered Lines: 2985
Relevant Lines: 3107
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 927

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 96.101%
Totals Coverage Status
Change from base Build 924: 0.1%
Covered Lines: 2982
Relevant Lines: 3103
💛 - Coveralls

zsol
zsol approved these changes Feb 24, 2019
View reviewed changes
Copy link
Collaborator

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JelleZijlstra JelleZijlstra merged commit 21ab37a into psf:master Feb 24, 2019
@JelleZijlstra JelleZijlstra deleted the removepy36 branch February 24, 2019 17:15
marsam added a commit to marsam/nix-review that referenced this pull request May 26, 2019
@marsam
Update black configuration
c6293ba 
py36 option was deprecated[1], in favor or target-version

[1] psf/black#724
marsam added a commit to marsam/nix-review that referenced this pull request May 26, 2019
@marsam
Update black configuration
f423cae 
py36 option was deprecated[1], in favor or target-version

[1] psf/black#724
@hugovk hugovk mentioned this pull request Jan 20, 2020
Merged
@gjulianm gjulianm mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsol zsol zsol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JelleZijlstra @coveralls @zsol