Detect board #34
Merged
Detect board #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't build M4 board at all - it doesn't have native networking, test is not useful, yet it fails on ArduinoCI for some unknown reason. Don't build ESP32 w/WiFi101.h examples, they are not designed to work. It was strange they actually worked before.
Only boards that have a default, intrinsic way of handling networking (like WiFi boards, such as MKR1000) are recognized. Also, only boards we could test or that have well-known implementation and good documentation are recognized.
davidnub
reviewed
Jun 18, 2019
| auto client = PubNub.publish(channel, msg); | ||
| if (!client) { | ||
| Serial.println("publishing error"); | ||
| delay(1000); |
There was a problem hiding this comment.
It would be better if we used a variable for the delay amount so we can change it all at once if we needed to.
There was a problem hiding this comment.
Well, that's just the thing, sometimes you actually want to make them different. Here they are the same mostly by accident/default. Arduino is infamous for such things, it's not a professional, but a "hobbyist" platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only boards that have a default, intrinsic way of handling
networking (like WiFi boards, such as MKR1000) are recognized.
Also, only boards we could test or that have well-known
implementation and good documentation are recognized.