-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(github-actions): migrate tests to GitHub Actions #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calls exponentially. however the tests are blocking on publish...
- Use `?` operator to bubble errors, instead of unwrap-with-panic (`expect` is the same as `unwrap` with a custom panic message)
- Switch to HashSet to allow O(1) removes and dedupe channels/groups
- Remove some of the commented code (saving the rest for later) - Replace the HashSets with a HashMap to Channels - A Channel is (in PubNub terms) what the client subscribes to (not publishes into) - The Channel will be used by the subscribe loop (TBD) to deliver messages to subscription streams (TBD)
- Successfully making requests - Lots of debug log noise, intentional - Haven't implemented Stream for Subscription, but that's the next big thing
…, remove an unnecessary dependency
Co-authored-by: Jay Oster <[email protected]>
This is a pattern with tests, so we probably can allow it, or apply special exclusions for well-known patterns.
* upgrade to tokio v1 Signed-off-by: Petros Angelatos <[email protected]> * fix warning about renamed lint Signed-off-by: Petros Angelatos <[email protected]> * fix cargo fmt and cargo clippy warnings Signed-off-by: Petros Angelatos <[email protected]> * update base64 crate to 0.13 Signed-off-by: Petros Angelatos <[email protected]> * update hmac and sha2 crates Signed-off-by: Petros Angelatos <[email protected]> * update derive builder to 0.10 Signed-off-by: Petros Angelatos <[email protected]> * uritemplate is unmaintained, switch to uritemplate-next Signed-off-by: Petros Angelatos <[email protected]> * update minimum rust version in CI to 1.46 rust >= 1.41 is required to build subtle, see: dalek-cryptography/subtle#77 rust >= 1.42 is required for the stabilization of the matches! macro rust >= 1.43 is required for inclusion of usize::MAX required by socket2 which is required by hyper rust >= 1.46 is required to allow match and if statements inside const expressions, which is required by socket2 which is required by hyper Signed-off-by: Petros Angelatos <[email protected]> * ignore failing test due to missing CI credentials Signed-off-by: Petros Angelatos <[email protected]>
Migrate PubNub SDK test suite from Travis to GitHub Actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test(github-actions): migrate tests to GitHub Actions
Migrate PubNub SDK test suite from Travis to GitHub Actions.