Allow Python dynamic provider resources to be constructed outside of __main__
#7755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`__main__` The underlying library `dill` that we use for serializing dynamic providers into Pulumi state for Python dynamic providers serializes classes differently depending on whether they are in `__main__` or in another module. We need the by-value serialization to be applied in all cases. uqfoundation/dill#424 is tracking adding the ability into `dill` to specify this by-value serialization explicitly, but until then, we will temporarily re-write the `__module__` of a provder class prior to serialization, so that `dill` behaves as we need for the dynamic provider use case. Fixes #7453.
added 2 commits
August 12, 2021 13:44
|
This is wonderful! Thanks very much, @lukehoban! |
justinvp
approved these changes
Aug 12, 2021
lukehoban
pushed a commit
that referenced
this pull request
Sep 1, 2021
…side of `__main__` (#7755)" This reverts commit ebb0e6a. The changes in #7755 introduced a regression tracked in #7795. It is not yet clear how to retain the desired behaviour introduced in #7755 while avoiding this regression, so for now we will revert those changes, and re-open #7453 to track a deeper fix. That fix may require making changes to upstream `dill` to properly support these serialization requirements. Fixes #7795.
lukehoban
pushed a commit
that referenced
this pull request
Sep 2, 2021
…side of `__main__` (#7755)" (#7889) This reverts commit ebb0e6a. The changes in #7755 introduced a regression tracked in #7795. It is not yet clear how to retain the desired behaviour introduced in #7755 while avoiding this regression, so for now we will revert those changes, and re-open #7453 to track a deeper fix. That fix may require making changes to upstream `dill` to properly support these serialization requirements. Fixes #7795.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying library
dillthat we use for serializing dynamic providers into Pulumi state for Python dynamic providers serializes classes differently depending on whether they are in__main__or in another module. We need the by-value serialization to be applied in all cases.uqfoundation/dill#424 is tracking adding the ability into
dillto specify this by-value serialization explicitly, but until then, we will temporarily re-write the__module__of a provider class prior to serialization, so thatdillbehaves as we need for the dynamic provider use case.Fixes #7453.