Ability to enable/disable "EnableSendFile" from base class call. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 It is a real problem with NFS and development environments. It would be nice to have this integrated instead of hardcode replacement of the line. |
| @@ -14,7 +14,8 @@ | |||
| # | |||
| class apache ( | |||
| $default_mods = true, | |||
| $serveradmin = 'root@localhost' | |||
| $serveradmin = 'root@localhost', | |||
| $sendfile = false, | |||
There was a problem hiding this comment.
Could you remove the trailing , for Puppet 2.6 compatibility please? And also align the = signs for style.
…t for style- - Calling serveradmin and sendfile variables on httpd.conf.erb templates using referencing variables to avoid them collide with Ruby function names.
|
Sure, @hunner . Thanks for the corrections! I've just commited both changes, and replaced the |
hunner
added a commit
that referenced
this pull request
Nov 9, 2012
Ability to enable/disable "EnableSendFile" from base class call.
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
* adding in pass_hash param for test environment * fixing rakefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some common environments ( working with Vagrant + Puppet and serving files from shared folder ), there's some problems when EnableSendfile is "on" (by default). It will be really helpful to allow disable this param from base class call.
Could you consider to include in main project?
Best regards!