Do not offload overriding LogFormats to httpd #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this might needs tests or documentation. |
|
@igalic thanks! Yeah, this definitely needs tests and docs. Do you think this would break existing configurations (i.e., is this backwards incompatible?) |
|
nope. shouldn't be. |
|
once again, i have no idea how to test for this, la la la… |
|
You need this rspec-puppet PR (rodjek/rspec-puppet#292) and then you can use this pattern (https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/spec/functions/type_spec.rb#L10-L13) without the puppetlabs_spec_helper mess. |
if an admin overrides one of the pre-existing formats, do not offload that to httpd: check for it, and replace it at configuration generation time.
underscorgan
pushed a commit
that referenced
this pull request
May 26, 2015
Do not offload overriding LogFormats to httpd
|
thanks @igalic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if an admin overrides one of the pre-existing formats, do not offload
that to httpd: check for it, and replace it at configuration
generation time.