Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1971) new $service_restart parameter to influence httpd. #1107

Merged
merged 1 commit into from
Apr 23, 2015
Merged

(#1971) new $service_restart parameter to influence httpd. #1107

merged 1 commit into from
Apr 23, 2015

Conversation

traylenator
Copy link
Contributor

Adds a new parameter to apache and apache::service to
permit restart paramter to the httpd service to be set.

For instance this allows to a restart to be configured
as apachectl graceful for instance.

Fixes https://tickets.puppetlabs.com/browse/MODULES-1971

the change is fully backwards compatible.

Adds a new parameter to apache and apache::service to
permit restart paramter to the httpd service to be set.

For instance this allows to a restart to be configured
as apachectl graceful for instance.

Fixes https://tickets.puppetlabs.com/browse/MODULES-1971

the change is fully backwards compatible.
@bmjen
Copy link
Contributor

bmjen commented Apr 23, 2015

@traylenator Thanks for the well put together PR! This will be a welcomed param addition.

bmjen added a commit that referenced this pull request Apr 23, 2015
(#1971) new $service_restart parameter to influence httpd.
@bmjen bmjen merged commit 4717399 into puppetlabs:master Apr 23, 2015
@traylenator traylenator deleted the restart_method branch April 30, 2015 07:58
@tenajsystems
Copy link
Contributor

@traylenator, how do i go about setting the service_restart parameter? I have tried setting service_restart like the code below but when i run puppet agent -t , no changes are made

class { 'apache':
  service_restart => '/usr/sbin/apachectl -k graceful',
}

Any thoughts on why the code I have above doesn't work?

@traylenator
Copy link
Contributor Author

There has to be a configuration chnage somewhere?

@tenajsystems
Copy link
Contributor

I thought it's supposed to make configuration changes but upon taking a second look, it appears it's not supposed to make any configuration changes and setting service_restart => '/usr/sbin/apachectl -k graceful' works as intended. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants