Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon Provider for A2Mod #123

Closed
wants to merge 1 commit into from
Closed

Conversation

ryandb
Copy link

@ryandb ryandb commented Nov 29, 2012

The RedHat a2Mod provider is not used for Amazon. This adds a provider for it.

Possible fix for #121

@tmclaugh
Copy link

I don't agree this is a fix for the amazon issue I indicated. I suggested the module stop using mod.d and make the a2mod resource a NOOP for RHEL and Amazon. The puppet a2mod type is analogous to a2enmod and a2dismod on Debian which is used to enable and disable installed modules from the current Apache config. RHEL and Amazon have no concept of enabled and disabled modules. If it's installed it's enabled.

@ryandb
Copy link
Author

ryandb commented Nov 30, 2012

Sorry I misunderstood your original request in Issue-121.

This IS a fix for a different issue however-- the issue being that this module does not work for Amazon Linux as it stands without this fix because there is no a2mod provider that will match.

This fix should still be accepted under the current design around a2mod providers.

If Issue-121 changes this design, we should make sure that Amazon Linux is also supported in the solution.

@tmclaugh
Copy link

tmclaugh commented Dec 4, 2012

I'd suggest a slight change to this commit. The file is exactly the same as the redhat.rb file except for the difference in the 'confine' and 'defaultfor' lines right? Could the redhat.rb file be altered to confine to either the 'redhat' $osfamily or the 'amazon' $operatingsystem. That would reduce the duplicate code and prevent skew if someone alters the redhat file and doesn't know to alter the amazon file.

@hunner
Copy link
Contributor

hunner commented Jun 5, 2013

Thanks for the PR! As the a2mod resource is no longer used internally by the module, and (as @tmclaugh correctly describes) is not particularly relevant on platforms other than Debian, I'm going to close this contribution.

@hunner hunner closed this Jun 5, 2013
traylenator pushed a commit to traylenator/puppetlabs-apache that referenced this pull request Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants