Added support for modsecurity parameter SecPcreMatchLimit and SecPcr… #1296
Conversation
|
hi @whotwagner this change looks ok, but it will definitely need a readme update to explain the new parameter |
|
Hello, I changed the README.md and also set the default-values to modsecurity's default-values as it is described here https://github.com/SpiderLabs/ModSecurity/wiki/Reference-Manual#SecPcreMatchLimit. |
| @@ -3,6 +3,8 @@ | |||
| $activated_rules = $::apache::params::modsec_default_rules, | |||
| $modsec_dir = $::apache::params::modsec_dir, | |||
| $modsec_secruleengine = $::apache::params::modsec_secruleengine, | |||
| $modsec_secpcrematchlimit = $::apache::params::modsec_secpcrematchlimit, | |||
| $modsec_secpcrematchlimitrecursion = $::apache::params::modsec_secpcrematchlimitrecursion, | |||
There was a problem hiding this comment.
do we really need the $modspec_ prefix within the mod::security module?
There was a problem hiding this comment.
good question, the parameter-name is long enough without the prefix. I used the prefix because all other parameter had this prefix too. i thought it might be some kind of naming convention.
There was a problem hiding this comment.
@whotwagner it seems to vary from module to module :S
…eMatchLimitRecursion fixed default variables for secpcrematchlimit(recursion) in params.pp added documentation for SecPcreMatchLimit and SecPcreMatchLimitRecursion. also changed the default value to 1500(its modsecurity's default value) removed modsec_-prefix from variable names
|
I changed(shortened) the variable-names and made a rebase again |
Added support for modsecurity parameter SecPcreMatchLimit and SecPcr…
|
Thanks for your work. |
…eMatchLimitRecursion
Set default PcreMatchLimit to 1000
fixed default variables for secpcrematchlimit(recursion) in params.pp