SSLProxyVerify #1311
Merged
SSLProxyVerify #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmjen I've added validation test and docs. |
| @@ -154,6 +154,7 @@ | |||
| 'ssl_verify_depth' => '3', | |||
| 'ssl_options' => '+ExportCertData', | |||
| 'ssl_openssl_conf_cmd' => 'DHParameters "foo.pem"', | |||
| 'ssl_proxy_verify' => 'require', | |||
There was a problem hiding this comment.
Since the template checks for existence of @ssl_proxy_verify before adding the line to the config, should this default be to undef? By setting a default, this means that the SSLProxyVerify line will always be present in the default config. Is that what we want?
cc/ @igalic
There was a problem hiding this comment.
@bmjen What would you suggest ? I might remove it. It doesn't bother me at all.
There was a problem hiding this comment.
Oops sorry @occelebi . I misread the diff and didn't see this was in the test and not manifest. This is fine the way it is! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added SSLProxyVerify directive in mod ssl.