Allow configuring mod_security's SecAuditLogParts #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 8, 2016 17:12
The default configuration for this includes "I" which is not always always suitable, e.g. if you cannot tolerate POST parameters appearing in your modsec_audit.log You may want to omit `I` if mod_security is protecting a hypothetical web service that accepts credit card data in a POST request, for example.
So it is valid for Debian-based systems also.
|
So many apologies about the many commits here. This is my first encounter with rspec, and I was initially not able to run the tests locally, so was coding blind. I believe it should now pass. I'm happy to squash the commits if desired. (Assuming this change is is accepted at all :-) ) |
|
It appears that the failure is unrelated to my change: |
|
Should I be adding an entry to the README as well, to document this new option? |
|
@stig yes please! |
| @@ -47,6 +47,8 @@ | |||
|
|
|||
| $vhost_include_pattern = '*' | |||
|
|
|||
| $modsec_audit_log_parts = 'ABIJDEFHZ' | |||
There was a problem hiding this comment.
According to the docs the default is ABCFHZ. Why did you choose this instead? It actually says that D isn't even implemented yet.
hunner
added a commit
that referenced
this pull request
Mar 10, 2016
Allow configuring mod_security's SecAuditLogParts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default configuration for this includes "I" which is not always
always suitable, e.g. if you cannot tolerate POST parameters appearing
in your modsec_audit.log
You may want to omit
Iif mod_security is protecting a hypotheticalweb service that accepts credit card data in a POST request, for
example.